Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • PRRT PRRT
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 41
    • Issues 41
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LARNLARN
  • PRRTPRRT
  • Merge requests
  • !4

Implementation dependant behaviour

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sven Liefgen requested to merge fix/red_package_encoding into develop Jul 31, 2020
  • Overview 0
  • Commits 5
  • Pipelines 5
  • Changes 3

In the current code, en/decoding of a block uses casts and memcpy to get from Payload to Buffer and vice versa. I.e. the whole payload is copied into a buffer including the header information. This buffer is then encoded via FEC and send. I think this makes the protocol implementation dependent, as not all implementations will use the same internal representation.

This merge request should fix this by encoding the Payload into the wire format as described by the protocol before encoding using FEC.

Edited Aug 24, 2020 by Sven Liefgen
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/red_package_encoding